-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reciprocal_ #23248
reciprocal_ #23248
Conversation
Thanks for contributing to Ivy! 😊👏 |
@@ -747,3 +747,8 @@ def remainder(self, y, name=None): | |||
|
|||
def is_floating_point(self): | |||
return paddle_frontend.is_floating_point(self._ivy_array) | |||
|
|||
@with_supported_dtypes({"2.5.1 and below": ("float32", "float64")}, "paddle") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @samthakur587 . There's a conflict here. It's a simple one. Can you resolve it please! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! @HaiderSultanArc i resolved the conflict. now its ready to merge. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @samthakur587 your tests are failing now. Can you have a look? Only look for your failing tests. You can ignore others. Thanks 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sherry30 🤔 do you know something about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
Hi! @HaiderSultanArc Now i have pull the latest changes its passing all the tests. 😄 hope now its ready to merge. 🚀 thanks |
added the reciprocal_ to paddle tensor frontend
In this PR i have added the reciprocal_ to paddle frontend tensor by calling the reciprocal itself from the the tensor class. passing all the backend tests.
Close #22297
Checklist