Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reciprocal_ #23248

Merged
merged 9 commits into from
Sep 25, 2023
Merged

reciprocal_ #23248

merged 9 commits into from
Sep 25, 2023

Conversation

samthakur587
Copy link
Contributor

@samthakur587 samthakur587 commented Sep 7, 2023

added the reciprocal_ to paddle tensor frontend

In this PR i have added the reciprocal_ to paddle frontend tensor by calling the reciprocal itself from the the tensor class. passing all the backend tests.

image

Close #22297

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 7, 2023
@@ -747,3 +747,8 @@ def remainder(self, y, name=None):

def is_floating_point(self):
return paddle_frontend.is_floating_point(self._ivy_array)

@with_supported_dtypes({"2.5.1 and below": ("float32", "float64")}, "paddle")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @samthakur587 . There's a conflict here. It's a simple one. Can you resolve it please! 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! @HaiderSultanArc i resolved the conflict. now its ready to merge. 🚀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @samthakur587 your tests are failing now. Can you have a look? Only look for your failing tests. You can ignore others. Thanks 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! the failing test is not related to my PR. what's happen i thing someone has made changes to testing pipeline. in local its showing this error.

image

I don't know what happening but its start after i pull the latest changes from ivy. 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sherry30 🤔 do you know something about this?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@samthakur587
Copy link
Contributor Author

Hi! @HaiderSultanArc Now i have pull the latest changes its passing all the tests. 😄 hope now its ready to merge. 🚀

image

thanks
sam

@HaiderSultanArc HaiderSultanArc merged commit e0dcfe2 into ivy-llc:main Sep 25, 2023
100 of 135 checks passed
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
@samthakur587 samthakur587 deleted the recp_ branch October 1, 2023 21:11
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reciprocal_
4 participants