-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added paddle.nanmean function frontend and test for it #23278
Conversation
Thanks for contributing to Ivy! 😊👏 |
@tomatillos hello, can you please review the PR and merge if things are fine |
@tomatillos hello can you please review the PR? |
Hi, looks good so far. Could you ensure that the test function is testing for NaN values too, otherwise we aren't properly testing the function for values it might encounter. You should be able to find examples of this in the other nan test functions in the file |
Yeah you are absolutely correct 😄. Will get back to you shortly. |
@tomatillos |
Does the same thing happen with |
Thanks for this :) |
PR Description
Added paddle.nanmean function and test for it.
Related Issue
Close #22885
Checklist
Socials:
discord - Sulaiman