Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added tridiagonal_solve in tensorflow frontend #23279

Merged
merged 49 commits into from
Dec 1, 2023

Conversation

AbdullahSabry
Copy link
Contributor

@AbdullahSabry AbdullahSabry commented Sep 8, 2023

Close #23043

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@AbdullahSabry
Copy link
Contributor Author

Hey @abdulasiraj

The tests seem to run fine here, however locally I'm facing an issue where it would timeout and display Skipped: Function not implemented in backend. in the end for all backends, while not directly referring to what function exactly.

I believe I added support for all possible formats for the function, check out the PR and let me know what to do next

Thanks!

@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@AbdullahSabry
Copy link
Contributor Author

@ivy-leaves

Issue was added in the description

@AbdullahSabry AbdullahSabry changed the title Added tridiagonal_solve in tensorflow frontend feat: Added tridiagonal_solve in tensorflow frontend Sep 18, 2023
Copy link
Contributor

@abdulasiraj abdulasiraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AbdullahSabry
tests are taking too long, any particular reason for this?

@AbdullahSabry
Copy link
Contributor Author

AbdullahSabry commented Sep 19, 2023

@abdulasiraj
Got the tests working by changing the structure for the other formats

@NripeshN
Copy link
Contributor

NripeshN commented Dec 1, 2023

LGTM!!!

@NripeshN NripeshN merged commit c66ee77 into ivy-llc:main Dec 1, 2023
16 of 20 checks passed
@AbdullahSabry AbdullahSabry deleted the tridiagonal_solve branch December 1, 2023 13:57
Kacper-W-Kozdon pushed a commit to Kacper-W-Kozdon/ivy that referenced this pull request Dec 5, 2023
Co-authored-by: NripeshN <nripesh14@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tridiagonal_solve
5 participants