added floor_ frontend function #23293

Aaryan562 · 2023-09-08T18:55:41Z

github-actions · 2023-09-08T18:56:00Z

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

Aaryan562 · 2023-09-08T19:20:35Z

@AlexandraPosta Could you pls review my PR. Thanks!

AlexandraPosta · 2023-09-10T18:58:07Z

ivy/functional/frontends/paddle/tensor/math.py

@@ -1,5 +1,5 @@
 # local
-from ..math import *  # noqa: F401
+from ..math import exp, floor, lerp, reciprocal, sqrt  # noqa: F401


I would not change this line, keep the changes to the functions that you contribute to.

AlexandraPosta · 2023-09-10T18:58:51Z

ivy/functional/frontends/paddle/tensor/math.py

@@ -21,6 +21,12 @@ def exp_(x, name=None):
    return ivy.inplace_update(x, exp(x))


+@with_supported_dtypes({"2.5.1 and below": ("float32", "float64")}, "paddle")


Please check the PaddlePaddle documentation for supported types.

AlexandraPosta · 2023-09-10T18:59:31Z

ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_math.py

-# --- Main --- #
-# ------------ #
-
-
 # ceil_


Again, please do not change code that it is not related to your functions

added floor_ frontend function

0689234

ivy-seed assigned AlexandraPosta Sep 8, 2023

ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 8, 2023

AlexandraPosta reviewed Sep 10, 2023

View reviewed changes

Aaryan562 closed this Sep 14, 2023

Aaryan562 deleted the floor_ branch September 14, 2023 08:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added floor_ frontend function #23293

added floor_ frontend function #23293

Aaryan562 commented Sep 8, 2023

github-actions bot commented Sep 8, 2023

Aaryan562 commented Sep 8, 2023

AlexandraPosta Sep 10, 2023

AlexandraPosta Sep 10, 2023

AlexandraPosta Sep 10, 2023

		@@ -21,6 +21,12 @@ def exp_(x, name=None):
		return ivy.inplace_update(x, exp(x))


		@with_supported_dtypes({"2.5.1 and below": ("float32", "float64")}, "paddle")

added floor_ frontend function #23293

added floor_ frontend function #23293

Conversation

Aaryan562 commented Sep 8, 2023

github-actions bot commented Sep 8, 2023

Aaryan562 commented Sep 8, 2023

AlexandraPosta Sep 10, 2023

Choose a reason for hiding this comment

AlexandraPosta Sep 10, 2023

Choose a reason for hiding this comment

AlexandraPosta Sep 10, 2023

Choose a reason for hiding this comment