Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added arctan2 math function for numpy #23315

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

Abhayooo7
Copy link
Contributor

PR Description

Related Issue

Close #22745

Checklist

  • Did you add a function? yes
  • Did you add the tests? yes
  • Did you follow the steps we provided? yes

Socials:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Sep 9, 2023
@paulaehab
Copy link
Contributor

Hello @Abhayooo7 thanks for contributing, everything look great for me 😄

@paulaehab paulaehab merged commit a240a4b into ivy-llc:main Sep 14, 2023
262 of 266 checks passed
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
Co-authored: paulaehab<eng.paulaehab@gmail.com>
@RohitSgh RohitSgh mentioned this pull request Sep 29, 2023
3 tasks
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Co-authored: paulaehab<eng.paulaehab@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arctan2
3 participants