Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: irfft2 function and test implemented. #23353

Merged
merged 13 commits into from
Sep 22, 2023

Conversation

Dhruv-Varshney-developer
Copy link
Contributor

@Dhruv-Varshney-developer Dhruv-Varshney-developer commented Sep 10, 2023

PR Description

irfft2 function and test added to paddle frontend. (paddle.fft.irfft2)

Related Issue

Close #22809

Checklist

  • Did you add a function? ✅
  • Did you add the tests? ✅
  • Did you follow the steps we provided? ✅

Socials:

Twitter: https://twitter.com/DhruvVa86396760

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 10, 2023
Dhruv-Varshney-developer

This comment was marked as resolved.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Dhruv-Varshney-developer Dhruv-Varshney-developer changed the title irfft2 function and test implemented. feat: irfft2 function and test implemented. Sep 13, 2023
@p3jitnath
Copy link
Contributor

Hi @Dhruv-Varshney-developer, would you mind look at the merge conflicts?
Thanks for contributing.

@Dhruv-Varshney-developer
Copy link
Contributor Author

Hey @nathzi1505, I have resolved the merge conflicts! Can you please look into this once again 🙂

@p3jitnath p3jitnath merged commit 70949cd into ivy-llc:main Sep 22, 2023
104 of 135 checks passed
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
Co-authored-by: nathzi1505 <41519676+nathzi1505@users.noreply.github.com>
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Co-authored-by: nathzi1505 <41519676+nathzi1505@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

irfft2
3 participants