feat: added ifft2 #23588
feat: added ifft2 #23588
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
ivy-leaves
added
the
JAX Frontend
|
@hello-fri-end Hey! Please, note that the function implemented is dependent on a backend function that might not have been implemented yet. The code for ifft2 in Jax frontend should be correct, and any errors should be resulting from calling ivy.ifft2. |
There was a problem hiding this comment.
Hey @roudik ! Thanks for working on this task, this is already a great PR. Just left a minor comments, please resolve it and I'll be happy to review the PR again. Thanks :)
| @handle_frontend_test( | ||
| fn_tree="jax.numpy.fft.ifft2", | ||
| dtype_values=helpers.dtype_and_values( | ||
| available_dtypes=helpers.get_dtypes("complex"), |
There was a problem hiding this comment.
| available_dtypes=helpers.get_dtypes("complex"), | |
| available_dtypes=helpers.get_dtypes("valid"), |
This should always be valid - if only complex data-type is supported by the function then that's what valid will return.
There was a problem hiding this comment.
This should always be
valid- if onlycomplexdata-type is supported by the function then that's whatvalidwill return.
Dear @hello-fri-end, just changed it to valid. Any other comments?
PR Description
Related Issue
Close #23585
Checklist
Socials: