Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added floor_ method in paddle frontend #23594

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

Aaryan562
Copy link
Contributor

Close #22648

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 14, 2023
@a0m0rajab a0m0rajab modified the milestone: #10388 Sep 14, 2023
@Aaryan562 Aaryan562 changed the title Added floor_ method in paddle frontend feat: Added floor_ method in paddle frontend Sep 15, 2023
@Aaryan562
Copy link
Contributor Author

@KareemMAX pls review it. Thanks

Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Aaryan562,

LGTM! merging now

@KareemMAX KareemMAX merged commit 5970ca5 into ivy-llc:main Sep 21, 2023
251 of 270 checks passed
@Aaryan562 Aaryan562 deleted the floor_ branch September 22, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

floor_
4 participants