feat: one_hot function of paddlepaddle #24153
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
ivy-leaves
added
the
Paddle Frontend
SamruddhiNavale
changed the title
There was a problem hiding this comment.
Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord
Here are some notes to understand our tests:
- We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that fails on this PR.
Please make sure they are passing. 💪
Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, so be patient.
|
Hey there |
|
hello @danielmunioz Let me know if any changes are required. |
|
Hey @SamruddhiNavale! Thanks for contributing! There is a small issue, the arguments of your function don't match the original function ones, they should be the same for the PR to pass, would you please fix that? and update the test accordingly? If you have any questions please feel free to reach out! |
|
@danielmunioz |
|
@danielmunioz |
There was a problem hiding this comment.
Hi @SamruddhiNavale
Thanks for the PR. Apologies for the delay on our end.
The PR looks clean. There is a little conflct which i fixed twice but for some reason my commit is not going through to your main. Can you resolve it and hopefully this will be ready to merge after I have another look. Please tag me or request a review when you sort out the little conflict. Thnx :)
|
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days. |
SamruddhiNavale
changed the title
PR Description
feat: one_hot function of paddlepaddle
Related Issue
Close #24151
##Checklist
Socials: