feat: add rfft for JAX frontend #24848
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
ivy-leaves
added
the
JAX Frontend
There was a problem hiding this comment.
Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord
Here are some notes to understand our tests:
- We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that fails on this PR.
Please make sure they are passing. 💪
Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.
|
Hi @SenayGe , the PR looks good. One small thing, could you discard the changes made on the demo_conf.py file? After that I can merge the PR. Thanks! |
Hi @KevinUli, thanks for reviewing the PR. The original submodule file was modified after I opened the PR. I have updated it now to sync the changes. Thanks! |
|
Hi @KevinUli, can you have a look? I have addressed what you pointed out and I think it looks good. |
|
LGTM! Thanks for the PR 😃 |
PR Description
Implemented rfft for JAX frontend
Related Issue
Close #23800
Checklist
Socials: