Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(paddle): Add mean method to Paddle Frontend #25950

Merged
merged 2 commits into from
Sep 24, 2023
Merged

feat(paddle): Add mean method to Paddle Frontend #25950

merged 2 commits into from
Sep 24, 2023

Conversation

Boghdady9
Copy link
Contributor

PR Description

Related Issue

Close #25943

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials:

github-actions[bot]
github-actions bot reviewed Sep 23, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 23, 2023
@Boghdady9
Copy link
Contributor Author

@hmahmood24

hmahmood24
hmahmood24 requested changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@hmahmood24 hmahmood24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Boghdady9, thanks a lot for the PR. The tests seem to be passing when running locally so it looks good to me. Can you just fix some of the lint issues with this PR? I recommend using pre-commit. Thanks!

@Boghdady9
Copy link
Contributor Author

image

@hmahmood24

hmahmood24
hmahmood24 approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@hmahmood24 hmahmood24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge! @Boghdady9 🚀

@hmahmood24 hmahmood24 merged commit 6d1838d into ivy-llc:main Sep 24, 2023
265 of 267 checks passed
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
@Boghdady9 @hmahmood24 @iababio
feat(frontends): Add mean method to Paddle Frontend (ivy-llc#25950)
0bef3ca 
Co-authored-by: hmahmood24 <hmahmood.bee16@gmail.com>
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
@Boghdady9 @hmahmood24 @druvdub
feat(frontends): Add mean method to Paddle Frontend (ivy-llc#25950)
0d29bcc 
Co-authored-by: hmahmood24 <hmahmood.bee16@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@hmahmood24 hmahmood24 hmahmood24 approved these changes

Assignees

@hmahmood24 hmahmood24

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mean
3 participants
@Boghdady9 @hmahmood24 @ivy-leaves