added unflatten (incomplete) #25975

HaoES · 2023-09-23T19:20:36Z

PR Description

added unflatten

Related Issue

Can you please check the implementation and guide me on how to write and run tests?

Close #25905

Checklist

Did you add a function?
Did you add the tests?
Did you run your tests and are your tests passing?
Did pre-commit not fail on any check?
Did you follow the steps we provided?

Socials:

github-actions

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

docs: correct typo in README
feat: implement dark mode"
fix: correct remove button behavior

Linting Errors

Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
No subject found

github-actions

Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord

Here are some notes to understand our tests:

We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that fails on this PR.

Please make sure they are passing. 💪

Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.

ivy/functional/ivy/experimental/manipulation.py

HaiderSultanArc · 2023-09-25T22:52:19Z

🤔 Seems like you have pushed a wrong commit for docs submodule

HaoES · 2023-09-25T23:03:29Z

@HaiderSultanArc I only modified three files but I see now that the commit modified also demos_conf.py which I did not touch at all. How can I fix this?

HaiderSultanArc · 2023-09-25T23:09:02Z

I think you can check what commit docs/demos submodule is on main branch. Then go to demos and checkout to that commit and then commit that 🤔

cd docs/demos
git checkout <COMMIT_HASH_ON_MAIN>
cd ../../
git add -A
git commit -m "update: demos submodule"
git push

HaoES · 2023-09-26T09:07:32Z

@HaiderSultanArc I just did that, I hope things are good now.

HaiderSultanArc · 2023-09-26T12:30:44Z

Yep it's good now. There are some failing tests. I think you need to implement backend implementations as well right? 🤔

HaoES · 2023-09-26T14:02:44Z

@HaiderSultanArc thank you for always replying, I don't think I should implement the backend implementation as well (The task is called: Add Instance methods to Pytorch Frontend) I guess now I should implement the tests, can you please guide on where I can learn how to do that?

HaiderSultanArc · 2023-09-26T14:15:51Z

@HaoES If you are working on a frontend task and the backend is not implemented then you will have to implement that before the frontend 😄
As you have implemented the functional API as well it means backends are not implemented. So you have to look through all the frameworks that we support torch, tensorflow, numpy, jax, paddle and see which ones do and don't have native unflatten implementation of their own.
That would tell you if you have to implement mixed, primary or compositional implementation of this function.

HaoES · 2023-09-27T11:22:51Z

@HaiderSultanArc the task I am working on is Add Instance Methods to PyTorch Frontend so it's only concerned with Pytorch (the only framework I know). pytorch have already an unflatten method that I used in the implementation, so I guess the backend side for pytorch is already taken care of? As for the other framework unfortunately I am not familiar with them, I just want to implement unflatten for pytorch as the issue says. Can you please check and tell me what are the next steps I need to do (I guess I should write tests no?). Thank you.

HaiderSultanArc · 2023-09-27T12:13:34Z

Hey @HaoES you can use the torch.unflatten method for torch backend. But for other backends you will need to implement the behaviour of unflatten with ivy functions if those backends don't have an implementation for this method. If let's say tensorflow also has unflatten then you can use that for tensorflow backend 😄

HaoES · 2023-09-27T14:16:50Z

@HaiderSultanArc I am very thankful for your constant feedback, I totally understand you, but what I understood is that my task focuses only on Pytorch Add Instance Methods to PyTorch Frontend. So I am only working on adding unflatten to Pytorch frontend only, adding it to tensorflow,paddle and the rest is out of the scope of this task, please correct me if I am wrong and if this issue is also about implementing the methods to other frameworks as well.

HaiderSultanArc · 2023-09-27T15:01:24Z

@HaoES PyTorch Frontend works with every backend. You can run PyTorch frontend with TensorFlow backend as well. So backend is a requirement for frontend functions, and all of them need to be implemented before frontend.

HaoES · 2023-09-28T08:12:05Z

@HaiderSultanArc I understand, I don't know how to implement unflatten for other backends unfortunately :/ I will take some time and check Deep Dive and documentation. And see if I can do that. Thank you for your assistance and patience.

KareemMAX

Hi, seems like you have changed docs/demos which you might have done by mistake. Can you revert that change because we can't merge with that change in place?

HaoES · 2023-09-28T11:58:07Z

Hello @KareemMAX thank you for your review, can you please help me figure out how to do it?
I already did this as pointed out by @HaiderSultanArc

cd docs/demos
git checkout <COMMIT_HASH_ON_MAIN>
cd ../../
git add -A
git commit -m "update: demos submodule"
git push

HaiderSultanArc · 2023-09-28T21:06:37Z

@HaiderSultanArc I understand, I don't know how to implement unflatten for other backends unfortunately :/ I will take some time and check Deep Dive and documentation. And see if I can do that. Thank you for your assistance and patience.

Sounds good to me 😄. Take your time!

HaiderSultanArc · 2023-09-28T21:06:56Z

Hello @KareemMAX thank you for your review, can you please help me figure out how to do it? I already did this as pointed out by @HaiderSultanArc
cd docs/demos
git checkout <COMMIT_HASH_ON_MAIN>
cd ../../
git add -A
git commit -m "update: demos submodule"
git push

It's fixed now. Pull the new changes and try these commands again

HaiderSultanArc · 2023-09-28T21:10:09Z

ivy/functional/ivy/manipulation.py

+@handle_out_argument
+@to_native_arrays_and_back
+@handle_array_function
+@handle_device_shifting


This seems to be undefined 🤔

honestly I don't have any idea what these decorators do XD I just copied them from the reshape function because I assumed that unflatten has the same behavior as reshape.

You also have to import them. You can copy the import as well from where you picked this up 😄

HaiderSultanArc

Current demos submodule commit on main branch of ivy is: 7c99cb5

Use the following commands:

git fetch upstream
cd docs/demos
git checkout 7c99cb5
cd ../../
git add -A
git commit -m "update: demos submodule"
git push origin PR

added unflatten

bdbbeec

github-actions bot reviewed Sep 23, 2023

View reviewed changes

ivy-leaves added PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist Ivy Functional API Ivy API Experimental Run CI for testing API experimental/New feature or request labels Sep 23, 2023

github-actions bot reviewed Sep 23, 2023

View reviewed changes

ivy-seed assigned mobley-trent Sep 23, 2023

HaiderSultanArc reviewed Sep 23, 2023

View reviewed changes

ivy/functional/ivy/experimental/manipulation.py Outdated Show resolved Hide resolved

HaoES added 2 commits September 24, 2023 16:20

Merge branch 'unifyai:main' into PR

0cd1713

added unflatten

d653432

HaoES requested a review from KareemMAX as a code owner September 24, 2023 16:27

HaoES marked this pull request as draft September 24, 2023 16:33

HaoES changed the title ~~added unflatten (uncomplete)~~ added unflatten (incomplete) Sep 24, 2023

HaoES requested a review from HaiderSultanArc September 25, 2023 13:20

update:demos submodule

3683fe2

KareemMAX suggested changes Sep 28, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/main' into PR

e88f73b

HaiderSultanArc reviewed Sep 28, 2023

View reviewed changes

HaiderSultanArc suggested changes Sep 28, 2023

View reviewed changes

HaiderSultanArc assigned HaiderSultanArc and unassigned mobley-trent Sep 28, 2023

HaoES closed this by deleting the head repository Oct 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added unflatten (incomplete) #25975

added unflatten (incomplete) #25975

HaoES commented Sep 23, 2023 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

HaiderSultanArc commented Sep 25, 2023

HaoES commented Sep 25, 2023

HaiderSultanArc commented Sep 25, 2023 •

edited

Loading

HaoES commented Sep 26, 2023

HaiderSultanArc commented Sep 26, 2023

HaoES commented Sep 26, 2023

HaiderSultanArc commented Sep 26, 2023

HaoES commented Sep 27, 2023

HaiderSultanArc commented Sep 27, 2023

HaoES commented Sep 27, 2023

HaiderSultanArc commented Sep 27, 2023 •

edited

Loading

HaoES commented Sep 28, 2023

KareemMAX left a comment

HaoES commented Sep 28, 2023

HaiderSultanArc commented Sep 28, 2023

HaiderSultanArc commented Sep 28, 2023 •

edited

Loading

HaiderSultanArc Sep 28, 2023

HaoES Sep 28, 2023

HaiderSultanArc Sep 28, 2023

HaiderSultanArc left a comment

added unflatten (incomplete) #25975

added unflatten (incomplete) #25975

Conversation

HaoES commented Sep 23, 2023 • edited Loading

PR Description

Related Issue

Checklist

Socials:

github-actions bot left a comment

Choose a reason for hiding this comment

PR Compliance Checks

Conventional Commit PR Title

github-actions bot left a comment

Choose a reason for hiding this comment

HaiderSultanArc commented Sep 25, 2023

HaoES commented Sep 25, 2023

HaiderSultanArc commented Sep 25, 2023 • edited Loading

HaoES commented Sep 26, 2023

HaiderSultanArc commented Sep 26, 2023

HaoES commented Sep 26, 2023

HaiderSultanArc commented Sep 26, 2023

HaoES commented Sep 27, 2023

HaiderSultanArc commented Sep 27, 2023

HaoES commented Sep 27, 2023

HaiderSultanArc commented Sep 27, 2023 • edited Loading

HaoES commented Sep 28, 2023

KareemMAX left a comment

Choose a reason for hiding this comment

HaoES commented Sep 28, 2023

HaiderSultanArc commented Sep 28, 2023

HaiderSultanArc commented Sep 28, 2023 • edited Loading

HaiderSultanArc Sep 28, 2023

Choose a reason for hiding this comment

HaoES Sep 28, 2023

Choose a reason for hiding this comment

HaiderSultanArc Sep 28, 2023

Choose a reason for hiding this comment

HaiderSultanArc left a comment

Choose a reason for hiding this comment

HaoES commented Sep 23, 2023 •

edited

Loading

HaiderSultanArc commented Sep 25, 2023 •

edited

Loading

HaiderSultanArc commented Sep 27, 2023 •

edited

Loading

HaiderSultanArc commented Sep 28, 2023 •

edited

Loading