Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reformatted the container_types function in the jax backend #26193

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

edielam
Copy link
Contributor

@edielam edielam commented Sep 27, 2023

PR Description

Reformatted the "container_types" function in the JAX backend as per the formatting instructions. Mainly:

  • Added type hint for return value
  • Added docstring with description, return value explanation, and usage example

Related Issue

Close #26188

Checklist

  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord

Here are some notes to understand our tests:

  • We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
    • Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
    • New Failures Introduced: This lists the tests that fails on this PR.

Please make sure they are passing. 💪

Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.

@edielam edielam changed the title Reformatting the container_types function in the jax backend feat: Reformatted the container_types function in the jax backend Sep 27, 2023
@Sam-Armstrong Sam-Armstrong merged commit 06f63e8 into ivy-llc:main Jul 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

container_types
4 participants