-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Paddle frontend API): added t tensor method and test #26276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord
Here are some notes to understand our tests:
- We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that fails on this PR.
Please make sure they are passing. 💪
Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Kartik0605 , thanks for creating this PR - it's already in very good shape. Just left a few minor comments, let's resolve those after which this is good to merge:)
ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_tensor.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Anwaar Khalid <shahanwaar.khalid8@gmail.com>
Co-authored-by: Anwaar Khalid <shahanwaar.khalid8@gmail.com>
…_tensor.py Co-authored-by: Anwaar Khalid <shahanwaar.khalid8@gmail.com>
@hello-fri-end i have updated the changes that you have requested, please take a look again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are no failures on the CI. Merging this now, thanks for the contribution @Kartik0605
PR Description
This PR will add t paddle frontend API method and its respective test.
Related Issue
Close #26056
Checklist
Socials