Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Paddle frontend API): added t tensor method and test #26276

Merged
merged 7 commits into from
Oct 4, 2023

Conversation

Kartik0605
Copy link
Contributor

PR Description

This PR will add t paddle frontend API method and its respective test.

Related Issue

Close #26056

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 28, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord

Here are some notes to understand our tests:

  • We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
    • Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
    • New Failures Introduced: This lists the tests that fails on this PR.

Please make sure they are passing. 💪

Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.

Copy link
Contributor

@hello-fri-end hello-fri-end left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Kartik0605 , thanks for creating this PR - it's already in very good shape. Just left a few minor comments, let's resolve those after which this is good to merge:)

ivy/functional/frontends/paddle/tensor/tensor.py Outdated Show resolved Hide resolved
ivy/functional/frontends/paddle/tensor/tensor.py Outdated Show resolved Hide resolved
Kartik0605 and others added 3 commits October 1, 2023 22:54
Co-authored-by: Anwaar Khalid <shahanwaar.khalid8@gmail.com>
Co-authored-by: Anwaar Khalid <shahanwaar.khalid8@gmail.com>
…_tensor.py

Co-authored-by: Anwaar Khalid <shahanwaar.khalid8@gmail.com>
@Kartik0605
Copy link
Contributor Author

Kartik0605 commented Oct 3, 2023

@hello-fri-end i have updated the changes that you have requested, please take a look again.

Copy link
Contributor

@hello-fri-end hello-fri-end left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are no failures on the CI. Merging this now, thanks for the contribution @Kartik0605

@hello-fri-end hello-fri-end merged commit 4cd7770 into ivy-llc:main Oct 4, 2023
257 of 269 checks passed
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
)

Co-authored-by: ivy-branch <ivy.branch@lets-unify.ai>
Co-authored-by: Anwaar Khalid <shahanwaar.khalid8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

t
4 participants