feat: add increment method to paddle frontend #26331
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ivy-leaves
added
Paddle Frontend
|
I made changes in the following files tensor.py, test_tensor.py,math.py,test_math.py |
|
@juliagsy kindly can you review the PR |
muhammadhammad-tech
changed the title
There was a problem hiding this comment.
Hey! Thanks for contributing! The increment method is relying on its functional version and it is currently being worked on in another issue and PR, I'll check back soonest possible when that it available because I wouldn't be able to test and make sure they are working correctly and as expected otherwise. Meanwhile, could you please remove all changes in the docs/demos folder as well as the functional version? Thanks!
|
thank you @juliagsy and @KareemMAX , i dont know how the docs/demos file got changed I am working on it. and kindly would you tell me should I remove my increment implementation from every file and make it once the increment function is done ? |
|
kindly can you guys help me on this docs/demos i am unable to revert it back i reverted all my changes upto merge 'main' commit, thank you |
|
@juliagsy hopefully resolved the conflicts can you look it again guide for further changes thank you |
|
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
|
could you please try The other looks good to me as of now, I'll test them out when the functional version is ready, will also attach that PR here so that we can check the status easily. #21369 Thanks! |
|
i followed these steps every time this PR had the conflict with the docs/demos file each time it got me demos file that i commit then the conflict ended but now i am doing nothing is happening, i tried your method but also doesnt work tbh i am confused |
|
|
|
should I use git rebase ?? will it be help full need help @juliagsy |
|
|
|
|
|
@muhammadhammad-tech Hey! apologies for the delay, hmm could you try a rebase within |
|
I guess merge is enough, haven't used rebase before on submodules |
|
@KareemMAX @juliagsy it fine or should ? what should i do ? thank you |
|
it showing no conflict at this moment. |
|
yeah, then I guess it's fine for now, since from the PR diff the commits are from internally instead of something you changed or committed in extra. for now let's see if the dependent PR is merged within the coming week, and we'll look into merging yours soon after, thanks again! |
|
Hey! it seems the contributor of another PR is inactive and closed their PR. Apologies for the hassle but you are now safe to add the functional version of |
muhammadhammad-tech
force-pushed
the
muhammadhammad-tech/issue26215
branch
from
34b2da0
to
19cb1a4
Compare
|
hey @juliagsy can you help i don't know what happened |
|
it got closed automatically i cant even reopen it can you help should i do it from scratch.. thank you need your help @juliagsy |
|
reopening it |
|
Hey! I haven't encountered this before too but I'm guessing its something to do with the force push, but you should be able to open a new PR through the branch in your fork, hope this is helpful! edit: unfortunately I'm unable to reopen it too |
|
okay thank you for the response |
Fixes #26215
PR Description
Implemented the increment method in both
math.py,test_math.py,tensor.py, andtest_tensor.py.Related Issue
Close #26215
Checklist
Socials