Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Lgamma to paddle frontend #26376

Closed
wants to merge 9 commits into from

Conversation

lukamdivani
Copy link
Contributor

@lukamdivani lukamdivani commented Sep 30, 2023

PR Description

added lgamma frontend to paddle

Related Issue

Close #26351

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 30, 2023
@lukamdivani lukamdivani marked this pull request as ready for review September 30, 2023 22:08
@lukamdivani
Copy link
Contributor Author

I don't think my PR introduces any new errors, let me know if anything else needs to be changed !

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@lukamdivani lukamdivani changed the title Lgamma paddle feat: added Lgamma to paddle frontend Oct 1, 2023
@lukamdivani
Copy link
Contributor Author

I added the function to the tensor class, I still think no new failed tests are introduced by my code, let me know if I should edit something

Copy link
Contributor

@YushaArif99 YushaArif99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lukaM19. The changes look good to me at a first glance. There are a few small changes I have requested above.
I am also noticing the CI tests for test_paddle_tensor_lgamma failing here with the following error:

ret = torch.as_tensor(obj, dtype=dtype, device=device)
E   TypeError: object of type 'Tensor' has no len()

Could you kindly look into this and ensure the relevant CI tests are all passing? Feel free to request a review once this is done. Thanks! 🙂

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Thank you for this PR, here is the CI results:


Failed tests:

This PR introduces the following new failing tests:
ivy_tests/test_ivy/test_frontends/test_paddle/test_math.py::test_paddle_kron,torch
ivy_tests/test_ivy/test_frontends/test_torch/test_indexing_slicing_joining_mutating_ops.py::test_torch_stack,torch

@lukamdivani
Copy link
Contributor Author

@YushaArif99 I made some changes and none of the tests associated with my changes and lgamma seem to fail, I would love to know if you think I should change something else

@lukamdivani
Copy link
Contributor Author

@YushaArif99 just wondering if you could take another look at the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lgamma
5 participants