-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added Lgamma to paddle frontend #26376
Conversation
I don't think my PR introduces any new errors, let me know if anything else needs to be changed ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
I added the function to the tensor class, I still think no new failed tests are introduced by my code, let me know if I should edit something |
ivy_tests/test_ivy/test_frontends/test_paddle/test_manipulation.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lukaM19. The changes look good to me at a first glance. There are a few small changes I have requested above.
I am also noticing the CI tests for test_paddle_tensor_lgamma
failing here with the following error:
ret = torch.as_tensor(obj, dtype=dtype, device=device)
E TypeError: object of type 'Tensor' has no len()
Could you kindly look into this and ensure the relevant CI tests are all passing? Feel free to request a review once this is done. Thanks! 🙂
Thank you for this PR, here is the CI results: Failed tests:This PR introduces the following new failing tests: |
@YushaArif99 I made some changes and none of the tests associated with my changes and lgamma seem to fail, I would love to know if you think I should change something else |
@YushaArif99 just wondering if you could take another look at the PR |
PR Description
added lgamma frontend to paddle
Related Issue
Close #26351
Checklist
Socials