Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Max Pool 3D to Paddle pooling.py #26587

Closed
wants to merge 3 commits into from
Closed

Conversation

kundakinte
Copy link
Contributor

PR Description

Added Max Pool 3D to pooling.py and tests

Related Issue

Close #26523

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Thank you for this PR, here is the CI results:


Failed tests:

This PR introduces the following new failing tests:
ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_elementwise.py::test_diff,paddle
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py::test_tensorflow_scalar_mul,numpy
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py::test_tensorflow_scalar_mul,jax
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py::test_tensorflow_scalar_mul,tensorflow
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py::test_tensorflow_scalar_mul,torch
ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py::test_torch_tensor_neg,jax
ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py::test_torch_tensor_neg,tensorflow
ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py::test_torch_tensor_neg,paddle

@kundakinte kundakinte closed this Oct 10, 2023
@kundakinte kundakinte reopened this Oct 10, 2023
@kundakinte
Copy link
Contributor Author

Hey @tomatillos, hope you're doing well, if you have time kindly review my pull request

@kundakinte kundakinte closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

max_pool3d
4 participants