Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added histogram paddle frontend and tests #26667

Closed
wants to merge 2 commits into from
Closed

feat: added histogram paddle frontend and tests #26667

wants to merge 2 commits into from

Conversation

lukaM19
Copy link
Contributor

@lukaM19 lukaM19 commented Oct 5, 2023

PR Description

Related Issue

Close #26663

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023 •
edited
Loading

Thank you for this PR, here is the CI results:

This pull request does not result in any additional test failures. Congratulations!

@lukaM19 lukaM19 marked this pull request as ready for review October 5, 2023 20:33
@lukaM19
Copy link
Contributor Author

lukaM19 commented Oct 5, 2023 •
edited
Loading

Hi @jieunboy0516 , the new failures which are introduced are not related to the function I implemented so I am a little confused, I would greatly appreciate any tips ! thank you

jieunboy0516
jieunboy0516 reviewed Oct 9, 2023
View reviewed changes
ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_tensor.py
class_tree=CLASS_TREE,
init_tree="paddle.to_tensor",
method_name="histogram",
values=_histogram_helper(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeError: _histogram_helper() missing 1 required positional argument: 'draw'
could you fix that please?

@jieunboy0516
Copy link
Contributor

Hi @jieunboy0516 , the new failures which are introduced are not related to the function I implemented so I am a little confused, I would greatly appreciate any tips ! thank you

Thanks for your contribution @lukaM19 . I dont think your code caused the new failure, should be something else. Please fix your test helper so that i can run the unit test! thx

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Oct 9, 2023
@ivy-seed ivy-seed assigned KareemMAX and unassigned jieunboy0516 Oct 14, 2023
@NripeshN
Copy link
Contributor

Hey @lukaM19,
Could you please fix the merge conflicts

@NripeshN NripeshN closed this Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieunboy0516 jieunboy0516 jieunboy0516 left review comments

Assignees

@NripeshN NripeshN

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

histogram
5 participants
@lukaM19 @jieunboy0516 @NripeshN @KareemMAX @ivy-leaves