Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(paddle): Add moveaxis method to Paddle Frontend #26735

Closed
wants to merge 8 commits into from
Closed

feat(paddle): Add moveaxis method to Paddle Frontend #26735

wants to merge 8 commits into from

Conversation

Tinny-Robot
Copy link

PR Description

added mode Instance Method to paddle.tensor.tensor.Tensor class. and added test case

Related Issue

Close #26616

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Thank you for this PR, here is the CI results:

This pull request does not result in any additional test failures. Congratulations!

sherry30
sherry30 suggested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Getting this error numpy.exceptions.AxisError: source: axis 0 is out of bounds for array of dimension 0 for numpy and getting similar error for other backends.

Can you look into it?
Thanks

ivy/functional/frontends/paddle/tensor/tensor.py Outdated Show resolved Hide resolved
@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Oct 9, 2023
@Tinny-Robot
Copy link
Author

Tinny-Robot commented Oct 10, 2023 •
edited
Loading

@sherry30
i have added the moveaxis method, and the test case and it passes every, can you help me review it?

@Tinny-Robot
Copy link
Author

@sherry30 I have made tye requested changes please review them.

@ivy-seed ivy-seed assigned tomatillos and unassigned sherry30 Oct 13, 2023
@Tinny-Robot
Copy link
Author

@tomatillos please review my or sir

@Sarvesh-Kesharwani
Copy link
Contributor

Hi @Tinny-Robot
please resolve the merge conflicts.

@Sarvesh-Kesharwani
Copy link
Contributor

Hi @Tinny-Robot,
the test cases are failing for all the backends, please work on fixing them.
image

@ivy-seed ivy-seed added the Stale label Mar 24, 2024
@Ishticode
Copy link
Contributor

Closing this due to inactivity for over 2 months after addition of tests were requested. Please feel free to reopen if you would like to continue working on this. Thank you :)

@Ishticode Ishticode closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherry30 sherry30 sherry30 requested changes

Assignees

@Sarvesh-Kesharwani Sarvesh-Kesharwani

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

moveaxis
8 participants
@Tinny-Robot @Sarvesh-Kesharwani @Ishticode @sherry30 @tomatillos @ivy-seed @ivy-leaves @ivy-branch