-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(paddle frontend): add index_sample function #26756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
Hi @Sam-Armstrong and @KareemMAX. I raised this PR to address the requested change. Kindly let me know if you require any additional info to help merge this to the main branch. Thank you |
@ksbharaj please could you add the corresponding frontend test? |
Hi @Sam-Armstrong. I believe this is already there from a previous PR. Please check: ivy/ivy_tests/test_ivy/test_frontends/test_paddle and the function test_paddle_index_sample() Let me know if that's the correct test, and if anything else is needed. |
Hi @Sam-Armstrong. Have you had a chance to review this? Kindly let me know if you need any more information from me |
@ksbharaj we also need a test in ivy/ivy_tests/test_ivy/test_frontends/test_paddle |
Hey @Sam-Armstrong |
Hi @Sam-Armstrong. I added the tests, but I think this still needs some rectifications. I think I am facing some issues getting the tests to work locally, so I can't debug effectively. |
Hi @Sam-Armstrong. Please do let me know. I would like to continue contributing but just need some help on how to do it correctly. Thank you |
Hi @ksbharaj, sorry for the slow reply. I'm not exactly sure what's going wrong with the test unfortunately, the other tests in the file seem to be failing for me also. I'll continue looking into it, but maybe for the time being could you resolve the merge conflicts with main? Thanks! |
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days. |
Closing this due to inactivity for over 6 months. Please feel free to reopen if you would like to continue working on this. Thank you :) |
PR Description
Added Index_sample for Paddle
Related Issue
Close #26495
Checklist
Socials