Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(numpy): add signbit #26845

Merged
merged 7 commits into from
Oct 25, 2023
Merged

feat(numpy): add signbit #26845

merged 7 commits into from
Oct 25, 2023

Conversation

RohitSgh
Copy link
Contributor

@RohitSgh RohitSgh commented Oct 9, 2023

PR Description

Adding signbit
https://numpy.org/doc/stable/reference/generated/numpy.signbit.html

Related Issue

Close #23332

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials:

https://x.com/iRohitSgh
https://www.linkedin.com/in/iRohitSgh

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@RohitSgh RohitSgh changed the title Added Function feat(numpy): add signbit Oct 9, 2023
@RohitSgh
Copy link
Contributor Author

RohitSgh commented Oct 9, 2023

Frontend Task Checklist

IMPORTANT NOTICE 🚨:

The Ivy Docs represent the ground truth for the task descriptions and this checklist should only be used as a supplementary item to aid with the review process.

Please note that the contributor is not expected to understand everything in the checklist. It's mainly here for the reviewer to make sure everything has been done correctly 🙂

LEGEND 🗺:

  • ❌ : Check item is not completed.
  • ✅ : Check item is ready for review.
  • 🆘 : Stuck/Doubting implementation (PR author should add comments explaining why).
  • ⏩ : Check is not applicable to function (skip).
  • 🆗 : Check item is implemented and does not require any edits.

CHECKS 📑:

    • ❌: The function/method definition is not missing any of the original arguments.
    • ❌: In case the function/method to be implemented is an alias of an existing function/method:
        • ❌: It is being declared as such by setting fun1 = fun2, rather than being re-implemented from scratch.
        • ❌: The alias is added to the existing function/method's test in the aliases parameter of handle_frontend_test/handle_frontend_method.
    • ❌: The naming of the function/method and its arguments exactly matches the original.
    • ❌: No defined argument is being ignored in the function/method's implementation.
    • ❌: In special cases where an argument's implementation should be pending due to an incomplete superset of an ivy function:
        • ❌: A ToDo comment has been added prompting to pass the frontend argument to the ivy function whose behavior is to be extended.
    • ❌: In case a frontend function is being added:
        • ❌: It is a composition of ivy functions.
        • ❌: In case the needed composition is long (using numerous ivy functions), a Missing Function Suggestion issue has been opened to suggest a new ivy function should be added to shorten the frontend implementation.
        • ❌: @to_ivy_arrays_and_back has been added to the function.
    • ❌: In case a frontend method is being added:
        • ❌: It is composed of existing frontend functions or methods.
        • ❌: If a required frontend function has not yet been added, the method may be implemented as a composition of ivy functions, making sure that:
          • ❌: @to_ivy_arrays_and_back has been added to the method.
          • ❌: A ToDo comment has been made prompting to remove the decorator and update the implementation as soon as the missing function has been added.
    • ❌: The function/method's test has been added (except in the alias case mentioned in <2>):
        • ❌: All supported arguments are being generated in handle_frontend_test/handle_frontend_method and passed to test_frontend_function/test_frontend_method.
        • ❌: The argument generation covers all possible supported values. Array sizes, dimensions, and axes adhere to the full supported set of the original function/method.
        • ❌: The available_dtypes parameter passed to the helper generating the function/method's input array is set to helpers.get_dtypes("valid"). If there are unsupported dtypes that cause the test to fail, they should be handled by adding @with_supported_dtypes/@with_unsupported_dtype to the function/method.
    • ❌: The PR is not introducing any test failures.
        • ❌: The lint checks are passing.
        • ❌: The implemented test is passing for all backends.
    • ❌: The PR closes a Sub Task issue linked to one of the open frontend ToDo lists.
    • ❌: The function/method and its test have been added to the correct .py files corresponding to the addressed ToDo list.
    • ❌: The PR only contains changes relevant to the addressed subtask.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Oct 9, 2023
@RohitSgh
Copy link
Contributor Author

Hi @hello-fri-end. Can you please review the proposed changes? Thanks!

Copy link
Contributor

@hello-fri-end hello-fri-end left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RohitSgh , thanks for creating this PR. Just left a minor comment, happy to review again once you're done with the changes. :)

@RohitSgh
Copy link
Contributor Author

RohitSgh commented Oct 16, 2023

Command

pytest -v ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_floating_point_routines.py::test_numpy_signbit

@RohitSgh
Copy link
Contributor Author

Ready for review, @hello-fri-end

Copy link
Contributor

@hello-fri-end hello-fri-end left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ivy.logical_or function does support the out argument, so we can pass it direclty :)

@RohitSgh
Copy link
Contributor Author

Ay update, @hello-fri-end ?

Copy link
Contributor

@hello-fri-end hello-fri-end left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There are no related failures on the CI, thanks for the awesome contribution and apologies for the delayed response 🙏

@hello-fri-end hello-fri-end merged commit 1c1a110 into ivy-llc:main Oct 25, 2023
255 of 269 checks passed
@RohitSgh RohitSgh deleted the signbit branch October 25, 2023 08:29
@RohitSgh RohitSgh mentioned this pull request Oct 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signbit
3 participants