-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(numpy): add signbit #26845
feat(numpy): add signbit #26845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Frontend Task ChecklistIMPORTANT NOTICE 🚨:The Ivy Docs represent the ground truth for the task descriptions and this checklist should only be used as a supplementary item to aid with the review process. Please note that the contributor is not expected to understand everything in the checklist. It's mainly here for the reviewer to make sure everything has been done correctly 🙂 LEGEND 🗺:
CHECKS 📑:
|
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
Hi @hello-fri-end. Can you please review the proposed changes? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @RohitSgh , thanks for creating this PR. Just left a minor comment, happy to review again once you're done with the changes. :)
...st_ivy/test_frontends/test_numpy/test_mathematical_functions/test_floating_point_routines.py
Outdated
Show resolved
Hide resolved
Command
|
Ready for review, @hello-fri-end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ivy.logical_or
function does support the out argument, so we can pass it direclty :)
ivy/functional/frontends/numpy/mathematical_functions/floating_point_routines.py
Outdated
Show resolved
Hide resolved
Ay update, @hello-fri-end ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! There are no related failures on the CI, thanks for the awesome contribution and apologies for the delayed response 🙏
PR Description
Adding
signbit
https://numpy.org/doc/stable/reference/generated/numpy.signbit.html
Related Issue
Close #23332
Checklist
Socials:
https://x.com/iRohitSgh
https://www.linkedin.com/in/iRohitSgh