Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irfft #26887

Closed
wants to merge 2 commits into from
Closed

irfft #26887

wants to merge 2 commits into from

Conversation

GOW7527
Copy link

@GOW7527 GOW7527 commented Oct 10, 2023

Implemented irfft frontend

PR Description

Related Issue

Close #26885

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Implemented irfft frontend
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@github-actions
Copy link
Contributor

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Oct 10, 2023
@ivy-seed ivy-seed assigned kurshakuz and unassigned ZoeCD Oct 13, 2023
Copy link
Contributor

@kurshakuz kurshakuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for your contribution!

Your implementation is currently throwing the following error. Can you please resolve it?

E               hypothesis.errors.Flaky: Inconsistent test results! Test case was Conclusion(status=Status.INTERESTING, interesting_origin=(<class 'KeyError'>, '/workspaces/ivy/ivy/functional/backends/jax/__init__.py', 52, (<class 'KeyError'>, '/workspaces/ivy/ivy/utils/_importlib.py', 65, (<class 'KeyError'>, '/workspaces/ivy/ivy/utils/_importlib.py', 65, (), ()), ()), ())) on first run but Conclusion(status=Status.INTERESTING, interesting_origin=(<class 'KeyError'>, '/workspaces/ivy/ivy_tests/test_ivy/helpers/testing_helpers.py', 145, (), ())) on second

/opt/miniconda/envs/multienv/lib/python3.10/site-packages/hypothesis/internal/conjecture/datatree.py:406: Flaky

@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@ivy-seed ivy-seed added the Stale label Mar 22, 2024
@Ishticode
Copy link
Contributor

Thank you very much for the PR. Closing this due to lack of activity with changes requested remaining unresolved for over 6 months. Please feel free to reopen if you would like to continue working on this. :)

@Ishticode Ishticode closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

irfft
8 participants