feat: Update general_functions.py by adding random_uniform_initializer #26970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
the
TensorFlow Frontend
|
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
|
Can you review this PR please. |
Dsantra92
suggested changes
Oct 13, 2023
Comment on lines
350
to
358
| ): | ||
| try: | ||
| minval = float(minval) | ||
| except (ValueError, TypeError): | ||
| minval = 0.0 | ||
| try: | ||
| maxval = float(maxval) | ||
| except (ValueError, TypeError): | ||
| maxval = 1.0 |
There was a problem hiding this comment.
No need to have the try except here. It will be handled in the backend. Also, you needs to add tests for the given function.
|
Hey, can you solve the merge conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #26962
PR Description
Related Issue
Closes #26962
Checklist
Socials