Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added max pool 3D to paddle pooling.py #27036

Closed
wants to merge 8 commits into from
Closed

feat: added max pool 3D to paddle pooling.py #27036

wants to merge 8 commits into from

Conversation

kundakinte
Copy link
Contributor

PR Description

Added Max Pool 3D to pooling.py and tests

Closes #26523

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

github-actions[bot]
github-actions bot reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@kundakinte kundakinte changed the title Max pool 3 d Added Max Pool 3D to Paddle pooling.py Oct 16, 2023
@github-actions
Copy link
Contributor

Thank you for this PR, here is the CI results:

This pull request does not result in any additional test failures. Congratulations!

@kundakinte kundakinte changed the title Added Max Pool 3D to Paddle pooling.py feat: Added Max Pool 3D to Paddle pooling.py Oct 16, 2023
@kundakinte kundakinte changed the title feat: Added Max Pool 3D to Paddle pooling.py feat: added max pool 3D to paddle pooling.py Oct 16, 2023
@kundakinte
Copy link
Contributor Author

Hello @tomatillos, i've closed the previous pull request, this one complies with all PR compliance checks

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Oct 16, 2023
@NripeshN NripeshN self-assigned this Nov 15, 2023
@NripeshN
Copy link
Contributor

Hi @kundakinte,
Tests are failing locally.
Please ensure pytest -v ivy_tests/test_ivy/test_frontends/test_paddle/tes t_nn/test_functional/test_pooling.py::test_paddle_max_pool3d
passes all the tests

@NripeshN
Copy link
Contributor

NripeshN commented Dec 6, 2023

Hey @kundakinte
Could you please take a look at this lint issue
https://github.com/unifyai/ivy/actions/runs/6953683796/job/18919212604?pr=27036#step:5:120

@NripeshN NripeshN closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@Sarvesh-Kesharwani Sarvesh-Kesharwani

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

max_pool3d
6 participants
@kundakinte @NripeshN @Sarvesh-Kesharwani @Fayad-Alman @ivy-leaves @ivy-branch