feat: add increment method to paddle frontend #27063
Conversation
Fixes ivy-llc#26215
Fixes ivy-llc#26215
Fixes ivy-llc#26215
Fixes ivy-llc#26215
Fixes ivy-llc#26215
…uhammadhammad-tech/ivy into muhammadhammad-tech/issue26215
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
|
really sorry for the mess i will be careful in my other PRs this one is just terrible, i am unable to resolve docs/demos conflict. will be looking forward for your response and guidance thank you @KareemMAX |
muhammadhammad-tech
changed the title
ivy-leaves
added
the
Paddle Frontend
|
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
No worries at all, you may revert the commits that involved the |
|
@KareemMAX is it good ? thank you. |
|
hey @KareemMAX kindly can you check it.. thank you |
Hey @muhammadhammad-tech, I'll leave it with @MuhammedAshraf2020 as he is your primary assignee. |
|
@MuhammedAshraf2020 kindly can you review it thank you |
|
Hey @muhammadhammad-tech, thank you for your contribution 🙏🏻 we appreciate it too much |
|
Hi @muhammadhammad-tech |
|
@Sarvesh-Kesharwani could you check |
There was a problem hiding this comment.
Hi @muhammadhammad-tech
Thanks for the PR. Sorry for the delays caused.
Mostly good. Could you untangle the tensor method and its test from other methods and the tests. It seems to take on part from other functions and perhaps is the reason of so many new failures at https://github.com/unifyai/ivy/actions/runs/7604484114/job/20707480593?pr=27063. Let me know if unclear. Should be ready to merge. Pleaser request a review when made the update and let me know if something is unclear. Thanks a lot :)
|
Thank you very much for the PR. Closing this due to lack of activity with changes requested remaining unresolved for over a month. Please feel free to reopen if you would like to continue working on this. :) |
Fixes #26215
PR Description
Implemented the increment method in both math.py, test_math.py, tensor.py, and test_tensor.py.
Related Issue
Close #26215
Checklist
Did you add a function?
Did you add the tests?
Did you run your tests and are your tests passing?
Did pre-commit not fail on any check?
Did you follow the steps we provided?
Socials