Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Wasserstein Loss, the Most Popular Loss Function for GANs #27207

Merged
merged 17 commits into from
Jul 13, 2024

Conversation

hi-sushanta
Copy link
Contributor

@hi-sushanta hi-sushanta commented Nov 4, 2023

Introducing the Wasserstein loss function - the crown jewel of GANs! This state-of-the-art loss function helps both the generator and discriminator reach new heights of performance. The results? Stunningly realistic generated images that even the most discerning eye would mistake for the real thing. It's like magic, but with math! 🎩

Here is my code!
Screenshot (10)

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@hi-sushanta
Copy link
Contributor Author

Does anyone see my changes?

@hi-sushanta
Copy link
Contributor Author

I believe that the community around this repository is no longer active, so I have decided to delete it.

@niixxaaa
Copy link
Contributor

Hi, you need to add a hypothesis test in this file ivy/ivy_tests/test_ivy/test_functional/test_nn/test_losses.py for the function you've created.
Thanks :)

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hi-sushanta
THank you very much for the effort put into this PR. Apologies for lack of correspondence you have received here.
The two tests that you have added seem to be failing as maybe seen in the logs here https://github.com/unifyai/ivy/actions/runs/8130590086/job/22219132685?pr=27207
under combined test results. For example, test dic wl has a simple failure such as AttributeError: 'list' object has no attribute 'is_integer'. If you are able to fix these issues, please request my review and I should be able to come back to you quickly. Thank you very much for your patience 🙂

@hi-sushanta
Copy link
Contributor Author

HI, @Ishticode can you help me find where I was using .is_integer() because I don't see it?

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was in the ci as seen here
image
I think it is due to the way the input dtypes are put in the tests as pointed for test_disc_wl below.

ivy_tests/test_ivy/test_functional/test_nn/test_losses.py Outdated Show resolved Hide resolved
@Ishticode
Copy link
Contributor

HI. As you can see the is_integer issue is not directly in your code but it comes from how your test expected dtypes to be passed. It should not be a list of lists. You should be able to run tests locally and see these issues easily. Thanks

@Sam-Armstrong Sam-Armstrong merged commit 2fc15c8 into ivy-llc:main Jul 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants