Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added missing assert to 3 comparison checks #27926

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

PR Description

In the following test function, these 3 lines are missing assert
https://github.com/unifyai/ivy/blob/f057407029669edeaf1fc49b90883978e4f0c3aa/ivy_tests/test_ivy/test_frontends/test_jax/test_numpy/test_mathematical_functions.py#L1106-L1108
Reference:
Comment under that PR (#27003 (comment))

Related Issue

Closes #27925

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Jan 16, 2024
@KareemMAX KareemMAX merged commit 2038f90 into ivy-llc:main Jan 16, 2024
265 of 277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing assert leading to useless comparison
4 participants