Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated paddle version mapping form 2.5.2 to 2.6.0 #27941

Merged
merged 3 commits into from
Jan 18, 2024
Merged

feat: Updated paddle version mapping form 2.5.2 to 2.6.0 #27941

merged 3 commits into from
Jan 18, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

PR Description

New version of PaddlePaddle is released. So, I have updated the version from 2.5.2 to 2.6.0.

Related Issue

Closes #

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

github-actions[bot]
github-actions bot reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@ivy-leaves ivy-leaves added Paddle Paddle Backend JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist labels Jan 17, 2024
KareemMAX
KareemMAX reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you only changed paddle related functions, but @vedpatwardhan can you check that this PR didn't introduce new errors?

vedpatwardhan
vedpatwardhan approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Feel free to merge @KareemMAX, thanks @Sai-Suraj-27 😄

KareemMAX
KareemMAX suggested changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the conflicts real quick? @Sai-Suraj-27

@Sai-Suraj-27
Copy link
Contributor Author

Can you merge the conflicts real quick? @Sai-Suraj-27

Done @KareemMAX. Please check now. 👍🏻

@KareemMAX KareemMAX merged commit 7e42474 into ivy-llc:main Jan 18, 2024
114 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@KareemMAX KareemMAX KareemMAX requested changes

@vedpatwardhan vedpatwardhan vedpatwardhan approved these changes

Assignees

@Sarvesh-Kesharwani Sarvesh-Kesharwani

Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist Paddle Paddle Backend PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sai-Suraj-27 @KareemMAX @vedpatwardhan @Sarvesh-Kesharwani @ivy-leaves