-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tensorflow Gather nd raw ops #28211
Conversation
I have been working on this issue with @he11owthere and @NripeshN But while I was working with @he11owthere I had issues where some of the test cases passed and some didn't so he consulted me with the fix I've made in this PR. Pls @vedpatwardhan look into this solution and let me know if there are any changes that needs to be made. |
Hey @TalhaKhalil, thanks for creating the PR, I'll leave this with @Ishticode to review as it's related to gather 😄 |
Hi @vedpatwardhan @Ishticode could you please provide me with any updates regarding the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @TalhaKhalil
Thank you very much for the PR. I have ran the tests locally with over 500 examples and they pass. I made a minor update to the function signature. Will merge now. Thanks for contributing :)
Hi @Ishticode, |
PR Description
Related Issue
Closes #27443
Checklist