-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Frontend Failing Test: torch.linalg.matrix_rank #28390
fix: Frontend Failing Test: torch.linalg.matrix_rank #28390
Conversation
Pytorch docs mistakenly say that matrix_rank() takes 'A' as the first argmunent, but it actually takes 'input'. Thus, parameter 'A' changed to 'input' in ivy.functional.frontends.torch.linalg.matrix_rank(). 'atol' and 'rtol' args were not being passed to the frontend function because testing function was eating them up. Hence added support for kwargs of same names. 'atol' and 'rtol' are set to 0, since matrix_rank outputs whole numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord.
For every PR opened, we run unit tests and comment the results in the PR to ensure the functionality remains intact.
Please make sure they are passing. 💪
If you want to check them from the action runners, you can open the display_test_results
job. 👀
It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that fail on this PR.
Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.
Hi @Ishticode, I have not received a review for the last 5 days. Please review the PR and tell if it is okay! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ZenithFlux
Thank you very much for the PR. Sorry for the delay.
The fix looks good for conflicting arg names between the func and the test functions but I will have a quick check later today as the change applies to a fundamental testing function and will merge asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for your contribution and patience @ZenithFlux
PR Description
Closes #28385
Closes #28388
Closes #28389
Checklist