Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Variable frontend methods setting ivy_array to frontend tensor #28423

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix: Variable frontend methods setting ivy_array to frontend tensor #28423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ivy/functional/frontends/tensorflow/python/ops/resource_variable_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,15 @@


class ResourceVariable(tf_frontend.Variable):
pass
def __repr__(self):
return (
repr(self._ivy_array).replace(
"ivy.array",
"ivy.functional.frontends.tensorflow.python.ops.resource_variable_ops.ResourceVariable",
)[:-1]
+ ", shape="
+ str(self._ivy_array.shape)
+ ", dtype="
+ str(self._ivy_array.dtype)
+ ")"
)
7 changes: 5 additions & 2 deletions ivy/functional/frontends/tensorflow/variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,22 +58,25 @@ def assign(self, value, use_locking=None, name=None, read_value=True):
as_array=False,
)
self._ivy_array = value._ivy_array
return self

def assign_add(self, delta, use_locking=None, name=None, read_value=True):
ivy.utils.assertions.check_equal(
delta.ivy_array.shape if hasattr(delta, "ivy_array") else ivy.shape(delta),
self.shape,
as_array=False,
)
self._ivy_array = tf_frontend.math.add(self._ivy_array, delta._ivy_array)
self._ivy_array = ivy.add(self._ivy_array, delta._ivy_array)
return self

def assign_sub(self, delta, use_locking=None, name=None, read_value=True):
ivy.utils.assertions.check_equal(
delta.ivy_array.shape if hasattr(delta, "ivy_array") else ivy.shape(delta),
self.shape,
as_array=False,
)
self._ivy_array = tf_frontend.math.subtract(self._ivy_array, delta._ivy_array)
self._ivy_array = ivy.subtract(self._ivy_array, delta._ivy_array)
return self

def batch_scatter_update(
self, sparse_delta, use_locking=None, name=None, read_value=True
Expand Down
Loading