-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed the logical_not not support the bfloat16 #28455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sam. Thanks for the PR.
def logical_not( | ||
x: paddle.Tensor, /, *, out: Optional[paddle.Tensor] = None | ||
) -> paddle.Tensor: | ||
if paddle.is_complex(x): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we seem to be removing the complex dtype handling. So is complex unsupported now or does it still work?
if it is unsupported then it should be marked in the unsupported dtype decorator above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it's working bcz the paddle.logical_not can handle the complex dtype also. here the paddle doc for this and i have tested this passing all tests in local.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @samthakur587
Will merge soon
fixed the logical_not not support the bfloat16 at paddle backend
fix support for bfloat16 at paddle backend that the paddle doesn't support the bfloat16 dtype and removed the `python if paddle.is_complex(x):
passing all tests at local.
Closes #28454
Checklist