-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixing the tests for ivy.Shape
method
#28470
Conversation
…shapes in the tensorflow backend
shape methods as they're not supposed to be implemented given that shape implements the Sequence interface. And these methods will always raise type errors if called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fnhirwa, thanks for creating the PR!
Actually these methods were primarily added because the methods exist in torch.Size
, tf.TensorShape
, etc. Could you please check if those classes have these methods? If they don't then ofc we can remove them from the ivy.Shape
class 😄
Yeah makes sense, So I think these are the ones we can add superset behaviour for🙄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Feel free to merge, thanks @fnhirwa 😄
PR Description
Hi, @vedpatwardhan and @Ishticode I walked through the
ivy.Shape
class and given that shape implements theSequence
like behaviour. I believe that some of the magic methods implemented for this class always raiseTypeError
and I decided to remove them as they are not needed for the implementation.Removed methods
__mod__
__rmod__
__rdiv__
__div__
__sub__
__rsub__
__int__
__floordiv__
After removing these methods I refactored all unit tests of the
ivy.Shape
methods as most of them were failing due to wrong passing of parameters.Related Issue
Closes #
Checklist
Socials