Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tf backend unflatten not supporting dim size inference #28496

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Sam-Armstrong
Copy link
Contributor

Add support for the shape argument containing a -1, indicating that the dimension size needs to be inferred. Also expand the torch frontend test for unflatten to cover this case.

@Sam-Armstrong Sam-Armstrong self-assigned this Mar 6, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Mar 6, 2024
@Sam-Armstrong Sam-Armstrong merged commit 1ad0a8d into ivy-llc:main Mar 7, 2024
136 of 141 checks passed
@Sam-Armstrong Sam-Armstrong deleted the torch-unflatten branch March 7, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants