-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Frontend Failing Test: paddle - math.paddle.diff #28497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ZJay07
Thank you very much for the PR.
I think restriciting max number of dims to be also 1 like min num of dims means that we are testing for only 1d arrays while paddles diff function should also be able to run multidimensional arrays. So can we put a higher limit on if it helps maybe 5 or 6?
@Ishticode it should worked now for multi dimensions :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be needing to do so much to get dim and dtype right for append and prepend after they are generated. Can you see if you can instead generate them right to begin with? like in the helpers used. There is a shared strategy used here but that doesn't seem to get the same dtype? maybe use a single array generate with num_arrays equal to two or something.
Let me know if something is not clear
Just fixed it to generate an array, let me know if this is the right fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good. Thank you very much :) @ZJay07
PR Description
2 errors:
Related Issue
Close #28495
Close #28527
Close #28526
Close #28525
Close #28524
Checklist
Socials