Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Frontend Failing Test: paddle - math.paddle.diff #28497

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

ZJay07
Copy link
Contributor

@ZJay07 ZJay07 commented Mar 6, 2024

PR Description

2 errors:

  1. dtype error, append, prepend and x are different dtypes hence causing an error, fix by casting append and preppend to the same dtype as x
  2. dim error x, append and prepend should be the same dim, fixed by making max_dim of x to be the same as the other 2

Related Issue

Close #28495
Close #28527
Close #28526
Close #28525
Close #28524

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@ZJay07 ZJay07 changed the title fixed paddle.math.diff Fix Frontend Failing Test: paddle - math.paddle.diff Mar 6, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Mar 6, 2024
@ZJay07 ZJay07 closed this Mar 8, 2024
@ZJay07 ZJay07 deleted the fixing-test-2 branch March 8, 2024 10:55
@ZJay07 ZJay07 restored the fixing-test-2 branch March 8, 2024 11:16
@ZJay07 ZJay07 reopened this Mar 8, 2024
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ZJay07
Thank you very much for the PR.
I think restriciting max number of dims to be also 1 like min num of dims means that we are testing for only 1d arrays while paddles diff function should also be able to run multidimensional arrays. So can we put a higher limit on if it helps maybe 5 or 6?

@ZJay07
Copy link
Contributor Author

ZJay07 commented Mar 11, 2024

@Ishticode it should worked now for multi dimensions :)

@ZJay07 ZJay07 requested a review from Ishticode March 11, 2024 17:09
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be needing to do so much to get dim and dtype right for append and prepend after they are generated. Can you see if you can instead generate them right to begin with? like in the helpers used. There is a shared strategy used here but that doesn't seem to get the same dtype? maybe use a single array generate with num_arrays equal to two or something.
Let me know if something is not clear

@ZJay07
Copy link
Contributor Author

ZJay07 commented Mar 31, 2024

Just fixed it to generate an array, let me know if this is the right fix!

@ZJay07 ZJay07 requested a review from Ishticode March 31, 2024 12:47
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good. Thank you very much :) @ZJay07

@Ishticode Ishticode merged commit 811302d into ivy-llc:main Apr 2, 2024
252 of 277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
3 participants