Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed math.paddle.conj for jax, numpy, tensorflow and torch #28512

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

ZJay07
Copy link
Contributor

@ZJay07 ZJay07 commented Mar 8, 2024

PR Description

Some dtypes in numeric aren't supported by paddle.conj, changed it so that it is more consistent with the paddle docs.
Not sure why float16 was not supported as well despite paddle docs mention it is supported.

FAILED ivy_tests/test_ivy/test_frontends/test_paddle/test_math.py::test_paddle_conj[cpu-tensorflow-False-False] - RuntimeError: (NotFound) The kernel with key (CPU, Undefined(AnyLayout), float16) of kernel conj is not registered. Selected wrong DataType float16. Paddle support following DataTypes: int32, int64, float64, complex128,...

ivy conj

ref : https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/conj_en.html#conj

Related Issue

Closes ##28511
Closes ##28510
Closes ##28509
Closes ##28508

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Mar 8, 2024
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZJay07 for the fix
float16 is mentioned as supported in paddle docs but upon actually checking with the function it throws error. so this set of supporte dtype specification is correct.
Will merge soon :)

@Ishticode Ishticode merged commit b355b8e into ivy-llc:main Mar 14, 2024
148 of 161 checks passed
@ZJay07 ZJay07 deleted the fixing-test3 branch March 26, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants