Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed frontend test for torch.Tensor.repeat #28583

Merged
merged 1 commit into from
Mar 16, 2024
Merged

fix: fixed frontend test for torch.Tensor.repeat #28583

merged 1 commit into from
Mar 16, 2024

Conversation

ZenithFlux
Copy link
Contributor

PR Description

  • Set max_size for 'repeat' array to be same as the max dims allowed by numpy as numpy was throwing an error.
  • Limited the size of resultant array to 2^28 elements (around 300 million). This is because without a limit the function was sometimes trying to generate a list of size more than 1 TB during testing.

Related Issue

Closes #28581
Closes #28580

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

@ZenithFlux
fix: fixed frontend test for torch.Tensor.repeat
133c93b 
Set max_size for 'repeat' array to be same as the max dims allowed by numpy.
Limited the size of resultant array to 2^28 elements.
@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Mar 13, 2024
Ishticode
Ishticode approved these changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @ZenithFlux
Thank you very for the efforts here

@Ishticode Ishticode merged commit e0791d1 into ivy-llc:main Mar 16, 2024
136 of 141 checks passed
@ZenithFlux ZenithFlux deleted the chaitanya/fixing_test_torch_repeat branch March 18, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishticode Ishticode Ishticode approved these changes

Assignees

@Ishticode Ishticode

Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
3 participants
@ZenithFlux @Ishticode @ivy-leaves