Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cov to the paddle frontend #28603

Merged
merged 6 commits into from
Jul 13, 2024
Merged

feat: Add cov to the paddle frontend #28603

merged 6 commits into from
Jul 13, 2024

Conversation

mtnvdsk
Copy link
Contributor

@mtnvdsk mtnvdsk commented Mar 14, 2024

close #28602

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@mtnvdsk mtnvdsk changed the title Add cov to the paddle frontend feat:Add cov to the paddle frontend Mar 14, 2024
@mtnvdsk mtnvdsk changed the title feat:Add cov to the paddle frontend feat: Add cov to the paddle frontend Mar 14, 2024
@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Mar 14, 2024
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mtnvdsk
Thanks for the PR. Currently test_paddle_cov seems to fail for all backends. For example in tf backend it throws error | raise ValueError("x1 has more than 2 dimensions") | ValueError: x1 has more than 2 dimensions
Can you check the logs (https://github.com/unifyai/ivy/actions/runs/8285269497/job/22673868692?pr=28603) under Combined Results and see if you can fix the issue. Feel free to request a review when done. Thank you very much

@Sam-Armstrong
Copy link
Contributor

We're shifting away from a focus on paddle frontends, but merging this anyway as the PR is pretty much ready to go.

@Sam-Armstrong Sam-Armstrong merged commit 084047b into ivy-llc:main Jul 13, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cov
5 participants