Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Frontend Failing Test: paddle - comparison_ops.torch.equal #28726

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Fix Frontend Failing Test: paddle - comparison_ops.torch.equal #28726

merged 2 commits into from
Apr 9, 2024

Conversation

ZJay07
Copy link
Contributor

@ZJay07 ZJay07 commented Apr 2, 2024 •
edited
Loading

PR Description

image
Failing due to very small precision error by paddle, fixed by restricting the min value of the test

Related Issue

Close #28725

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@ZJay07 ZJay07 marked this pull request as ready for review April 2, 2024 19:41
@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Apr 2, 2024
Ishticode
Ishticode approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks @ZJay07 for the pr

@Ishticode Ishticode merged commit 1c56274 into ivy-llc:main Apr 9, 2024
149 of 157 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishticode Ishticode Ishticode approved these changes

Assignees

@Ishticode Ishticode

Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Frontend Failing Test: paddle - comparison_ops.torch.equal
3 participants
@ZJay07 @Ishticode @ivy-leaves