Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tracing ivy.set_item with Ellipsis/unbound slices #28771

Merged
merged 4 commits into from
Jun 24, 2024
Merged

fix: tracing ivy.set_item with Ellipsis/unbound slices #28771

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09f4794
add integration testing
Sam-Armstrong Jun 19, 2024
cb77283
fix: tracing ivy.set_item with Ellipsis/unbound slices
Sam-Armstrong Jun 20, 2024
0647f73
Merge branch 'main' into ivy-set-item
Sam-Armstrong Jun 20, 2024
d36ae2c
add todo note to the added logic
Sam-Armstrong Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ivy/functional/ivy/general.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2879,6 +2879,21 @@ def set_item(
ivy.array([[ 0, -1, 20],
[10, 10, 10]])
"""
if (
isinstance(query, (list, tuple)) and
any([
q is Ellipsis or (
isinstance(q, slice) and q.stop is None
) for q in query
])
):
# use numpy for item setting when an ellipsis or unbounded slice is present,
# as they would otherwise cause static dim sizes to be traced into the graph
# NOTE: this does however cause tf.function to be incompatible
np_array = x.numpy()
np_array[query] = np.asarray(val)
return ivy.array(np_array)

if copy:
x = ivy.copy_array(x)
if not ivy.is_array(val):
Expand Down
Loading