-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(torch-frontend): fix test_torch_max_pool2d #28790
fix(torch-frontend): fix test_torch_max_pool2d #28790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a couple of minor tweaks, but otherwise this looks good. Thanks for the contribution @nicolasb0! 😁
Thanks a lot @Sam-Armstrong ! But I am under the impression that both of your commits make the Paddle backend fail. Do you get a different result when running "python -m pytest ivy_tests/test_ivy/test_frontends/test_torch/test_nn/test_functional/test_pooling_functions.py::test_torch_max_pool2d"? |
@nicolasb0 We've shifted our focus away from paddle frontends and backends, as we're a much smaller team now. So I didn't look into the test for paddle, only the other backends. If you want to work on fixing the test for paddle, you're more than welcome to, but it isn't something that myself or the team will be able to look into right now. Apologies! |
PR Description
Related Issue
Close #28764
Checklist