-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve failing test cases for torch.linalg.norm #28805
fix: resolve failing test cases for torch.linalg.norm #28805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @adity1729, thanks for the contribution!
I think the only problem with the test is the dtype of the returned tensor. Can you make the changes I suggested and confirm that fixes the test? Then we should be good to merge.
Thanks!
max_num_dims=4, # limit maximum dimensions | ||
min_dim_size=2, # set minimum dimension size | ||
max_dim_size=10, # set maximum dimension size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max_num_dims=4, # limit maximum dimensions | |
min_dim_size=2, # set minimum dimension size | |
max_dim_size=10, # set maximum dimension size |
I don't think we need these to fix the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested it we need max_num_dims=4 otherwise it is giving this error
E hypothesis.errors.InvalidArgument: ListStrategy(one_of(floats(min_value=-100.0, max_value=-3.097532938251384e-35, allow_nan=False, allow_infinity=False, allow_subnormal=False, width=32), floats(min_value=3.097532938251384e-35, max_value=100.0, allow_nan=False, allow_infinity=False, allow_subnormal=False, width=32)), min_size=45_000, max_size=45_000) can never generate an example, because min_size is larger than Hypothesis supports. Including it is at best slowing down your tests for no benefit; at worst making them fail (maybe flakily) with a HealthCheck error.
E while generating 'args' from _get_axis_and_p()
E
Co-authored-by: Sam Armstrong <88863522+Sam-Armstrong@users.noreply.github.com>
Co-authored-by: Sam Armstrong <88863522+Sam-Armstrong@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
PR Description
Related Issue
Close #28690
Closes #
Checklist
Socials