add minimum in mathematical function #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JLU-Neal Could we ready to merge plz check |
AmeenUrRehman
changed the title
AmeenUrRehman
changed the title
AmeenUrRehman
changed the title
|
@JLU-Neal could you plz check my code plz |
|
@djl11 could you plz check my code and could we ready to merge Thank You! |
AmeenUrRehman
commented
Aug 29, 2022
|
@juliagsy Could you plz review my code and check if we merge this |
|
Hey there! ahh sure, I'll review soon, sorry for the delay! |
juliagsy
suggested changes
Aug 29, 2022
ivy/functional/frontends/numpy/mathematical_functions/extrema_finding.py
Outdated
Show resolved
Hide resolved
...tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_extrema_finding.py
Show resolved
Hide resolved
...tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_extrema_finding.py
Outdated
Show resolved
Hide resolved
...tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_extrema_finding.py
Outdated
Show resolved
Hide resolved
|
@juliagsy Plz review this I've try to resolve all issues |
juliagsy
suggested changes
Aug 30, 2022
| @handle_cmd_line_args | ||
| @given( | ||
| dtype_and_x=helpers.dtype_and_values( | ||
| available_dtypes=ivy_np.valid_float_dtypes, |
There was a problem hiding this comment.
please also add a parameter num_arrays=2 in this helper functions
|
@juliagsy Thank You! for your guidance plz review the code I've fixes the issue |
juliagsy
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add minimum mathematical function one of the tasks of #1525
resolves #3715