added arcsinh to numpy #3805
added arcsinh to numpy #3805
Conversation
ivy/functional/frontends/numpy/mathematical_functions/hyperbolic_functions.py
Outdated
Show resolved
Hide resolved
...st_ivy/test_frontends/test_numpy/test_mathematical_functions/test_np_hyperbolic_functions.py
Outdated
Show resolved
Hide resolved
...st_ivy/test_frontends/test_numpy/test_mathematical_functions/test_np_hyperbolic_functions.py
Outdated
Show resolved
Hide resolved
...st_ivy/test_frontends/test_numpy/test_mathematical_functions/test_np_hyperbolic_functions.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Firstly, I do not think you should include the init.pyc file in this pull request.
Secondly, you have some formatting errors with your code:
ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_np_hyperbolic_functions.py:113:1: E302 expected 2 blank lines, found 1
ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_np_hyperbolic_functions.py:117:5: E128 continuation line under-indented for visual indent
ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_np_hyperbolic_functions.py:125:13: E123 closing bracket does not match indentation of opening bracket's line
ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_np_hyperbolic_functions.py:126:9: E123 closing bracket does not match indentation of opening bracket's line
ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_np_hyperbolic_functions.py:130:1: E302 expected 2 blank lines, found 1
ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_np_hyperbolic_functions.py:132:17: E251 unexpected spaces around keyword / parameter equals
ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_np_hyperbolic_functions.py:159:13: E251 unexpected spaces around keyword / parameter equals
ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_np_hyperbolic_functions.py:159:15: E251 unexpected spaces around keyword / parameter equals
Secondly, TypeError: arcsinh() got an unexpected keyword argument 'axis' in your test, so you should not have axis passed into the test. This also implies that you should not just copy and paste from other examples but you need to change the code according the arcsinh function, which does not have an axis and need where argument the same size as the input array. Thank you.
#3799