Implemented sinc in the backend

[pj-mathematician]

Can you review and please list the additions/deletions I should incorporate?
And I will also need help with the doc string for ivy/elementwise.py

Thanks

[Unevilicorn]

Hi,

Could you also link the issue this relates to. This is so that it's easier for us to track what's being done.
The test is failing for sinc, you can see by going through the checks near the bottom of this page, click on detail on the row for test-core-ivy / run-nightly-tests ({backend}, elementwise) then click on Run Functional-Core Test

Thanks

[pj-mathematician]

@Unevilicorn thank you for the review, I will fix the tests by EOD.

sinc is a part of the functional API and is referenced in the Frontend TODO lists #12 , #1525 and #3612
But when I started the Frontend sinc I noticed that it isn't present in the backend at all. Hence I wrote the backend implementations. I believe it should be added to the list here #3856 . I have opened a separate issue to track this here #4447

[Unevilicorn]

I would actually recommend doing this compositionally then, since this function isn't too complex to compose, you can see it's behaviour from pytorch docs.

I'll take another look, and check if this should be added to the list 👍

[pj-mathematician]

I understand. So instead of adding any backend functions, I should implement sinc compositionally to only the frontend files of Numpy and Torch, as mentioned in the frontend todo tasks, right?

[Unevilicorn]

Yeah, that's the simplest way to go about it, just implementing them compositionally in the frontend for your framework. However it does feel like it could be added as an extension, I'll let you know when I find out if this should be added or not.

[pj-mathematician]

Alright then! Closing this PR for now, and will work on the frontend as you suggested. Let me know if there is a need for it in the backend, I'd love to get back on it 🙌🏻

Thanks alot for your help!!

[Unevilicorn]

Hi @pj-mathematician,
I've been told that this function should be added to Ivy and it's now on the extension list. If you would like, you can continue this PR and try to implement it, otherwise you can just leave this closed and someone else can pick up that task.
Thanks

[pj-mathematician]

@Unevilicorn , I have opened #4462 to work on this. Thank you for the clarification