Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements the convolve function in the numpy frontend #7083

Merged
merged 7 commits into from
Nov 17, 2022
Merged

Implements the convolve function in the numpy frontend #7083

merged 7 commits into from
Nov 17, 2022

Conversation

DarthEmpty
Copy link
Contributor

@DarthEmpty DarthEmpty commented Nov 15, 2022 •
edited by p3jitnath
Loading

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Nov 16, 2022
@p3jitnath p3jitnath changed the title Implements the convolute function in the numpy frontend Implements the convolve function in the numpy frontend Nov 16, 2022
@p3jitnath
Copy link
Contributor

p3jitnath commented Nov 16, 2022 •
edited
Loading

Hi @DarthEmpty, thanks for the PR.
I see some tests especially the lint-check and the test-frontend-numpy not passing.
Mind having a look at those? Also, if you haven't pull the new commits from the master branch, feel free to do so as in the current version these two checks are OK. For related help you can also see here : https://lets-unify.ai/ivy/contributing.html.

Just have a look again and submit it for review. I will look at the changes again. 😊

@p3jitnath p3jitnath merged commit ddff651 into ivy-llc:master Nov 17, 2022
KevinUnadkat pushed a commit to KevinUnadkat/ivy that referenced this pull request Dec 4, 2022
@DarthEmpty @p3jitnath @KevinUnadkat
Implements the convolve function in the numpy frontend (ivy-llc#7083)
77be305 
Co-authored-by: nathzi1505 <41519676+nathzi1505@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@p3jitnath p3jitnath

Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarthEmpty @p3jitnath @ivy-leaves