Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added diff in numpy frontend #9929

Merged
merged 2 commits into from
Feb 10, 2023
Merged

added diff in numpy frontend #9929

merged 2 commits into from
Feb 10, 2023

Conversation

melabady1
Copy link
Contributor

Close #9919

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Jan 23, 2023
@p3jitnath
Copy link
Contributor

Hey @melabady1, thanks for the commit.
Looks like there are errors that might have caused the pr tests to fail.
Would you mind checking them for me? If you think the tests are not causing because of that, feel free to comment that here.

@melabady1
Copy link
Contributor Author

Hello @nathzi1505
I already checked the failed tests. They aren't due to my code.
the tests fails mainly due to two old functions (test_numpy_nancumsum and test_numpy_nansum)
these functions case 7 checks to fail(see sample screenshot attached ).
and there is 1 cancelled check(test-frontend-numpy / run-nightly-tests ) i guess due to timeout.

Screenshot from 2023-01-25 07-45-41

@melabady1
Copy link
Contributor Author

Hey @melabady1, thanks for the commit. Looks like there are errors that might have caused the pr tests to fail. Would you mind checking them for me? If you think the tests are not causing because of that, feel free to comment that here.

Hello @nathzi1505
would you please check my reply to you and review the code

@ivy-seed ivy-seed added the Stale label Feb 8, 2023
@ivy-seed
Copy link

ivy-seed commented Feb 8, 2023

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@melabady1
Copy link
Contributor Author

@nathzi1505

please review this pr

@p3jitnath p3jitnath merged commit 9caccb4 into ivy-llc:master Feb 10, 2023
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 17, 2023
@melabady1 @p3jitnath
added diff in numpy frontend (ivy-llc#9929)
5f04728 
Co-authored-by: nathzi1505 <41519676+nathzi1505@users.noreply.github.com>
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 23, 2023
@melabady1 @p3jitnath
added diff in numpy frontend (ivy-llc#9929)
e2a864e 
Co-authored-by: nathzi1505 <41519676+nathzi1505@users.noreply.github.com>
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
@melabady1 @p3jitnath
added diff in numpy frontend (ivy-llc#9929)
2ef9a64 
Co-authored-by: nathzi1505 <41519676+nathzi1505@users.noreply.github.com>
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
@melabady1 @p3jitnath
added diff in numpy frontend (ivy-llc#9929)
841c752 
Co-authored-by: nathzi1505 <41519676+nathzi1505@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@p3jitnath p3jitnath

Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

diff
4 participants
@melabady1 @p3jitnath @ivy-seed @ivy-leaves