Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: .d.ts type error #83

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

xiaoxiangmoe
Copy link

In TypeScript project without skipLibCheck, it will throw error

Cannot find module '@src/parse/parseNodeTypes' or its corresponding type declarations.ts(2307)

Also, #51 this is wrong.
According to https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing, the only way to correct provide types for both Node ESM and CJS is to have two separate declaration files, so we need to generate .d.mts and .d.cts upon build.

So I bundle .d.ts to generate lib/index.d.ts and lib/index.d.mts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant