Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build issue : TerminalApp.h missing #1

Merged
merged 1 commit into from
May 17, 2019
Merged

Fix build issue : TerminalApp.h missing #1

merged 1 commit into from
May 17, 2019
+4 −1

Conversation

iwhp
Copy link
Owner

@iwhp iwhp commented May 17, 2019

Summary of the Pull Request

Compile/Build issue:
[Build Error] Cannot open include file: 'winrt/TerminalApp.h': No such file or directory

References

Related to microsoft#659 and microsoft#489, microsoft#565

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

@iwhp iwhp merged commit 2b96185 into master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iwhp