Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug of commit is not an ancestor of the current commit #39

Closed
wants to merge 1 commit into from

Conversation

xdays
Copy link

@xdays xdays commented Aug 24, 2019

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

Fix the bug of commit is not an ancestor of the current commit

Description

if we push a new branch and the commit id of previous job is not an ancestor of the current commit then RETURN_CODE is 1, when the script really find an ancestor of the current commit
git merge-base --is-ancestor $COMMIT_FROM_JOB_NUM $CIRCLE_SHA1 || { RETURN_CODE=$?; }, the git command return 0, but { RETURN_CODE=$?; } will not executed due to ||

@xdays
Copy link
Author

xdays commented Aug 29, 2019

I will close this PR as there's already one #36 for fixing this bug.

@xdays xdays closed this Aug 29, 2019
@xdays xdays mentioned this pull request Aug 29, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant